brew/Library/Homebrew/locale.rb
Issy Long 45978435e7
rubocop: Use Sorbet/StrictSigil as it's better than comments
- Previously I thought that comments were fine to discourage people from
  wasting their time trying to bump things that used `undef` that Sorbet
  didn't support. But RuboCop is better at this since it'll complain if
  the comments are unnecessary.

- Suggested in https://github.com/Homebrew/brew/pull/18018#issuecomment-2283369501.

- I've gone for a mixture of `rubocop:disable` for the files that can't
  be `typed: strict` (use of undef, required before everything else, etc)
  and `rubocop:todo` for everything else that should be tried to make
  strictly typed. There's no functional difference between the two as
  `rubocop:todo` is `rubocop:disable` with a different name.

- And I entirely disabled the cop for the docs/ directory since
  `typed: strict` isn't going to gain us anything for some Markdown
  linting config files.

- This means that now it's easier to track what needs to be done rather
  than relying on checklists of files in our big Sorbet issue:

```shell
$ git grep 'typed: true # rubocop:todo Sorbet/StrictSigil' | wc -l
    268
```

- And this is confirmed working for new files:

```shell
$ git status
On branch use-rubocop-for-sorbet-strict-sigils
Untracked files:
  (use "git add <file>..." to include in what will be committed)
        Library/Homebrew/bad.rb
        Library/Homebrew/good.rb

nothing added to commit but untracked files present (use "git add" to track)

$ brew style
Offenses:

bad.rb:1:1: C: Sorbet/StrictSigil: Sorbet sigil should be at least strict got true.
^^^^^^^^^^^^^

1340 files inspected, 1 offense detected
```
2024-08-12 15:24:27 +01:00

114 lines
2.8 KiB
Ruby

# typed: true # rubocop:todo Sorbet/StrictSigil
# frozen_string_literal: true
# Representation of a system locale.
#
# Used to compare the system language and languages defined using the cask `language` stanza.
class Locale
# Error when a string cannot be parsed to a `Locale`.
class ParserError < StandardError
end
# ISO 639-1 or ISO 639-2
LANGUAGE_REGEX = /(?:[a-z]{2,3})/
private_constant :LANGUAGE_REGEX
# ISO 15924
SCRIPT_REGEX = /(?:[A-Z][a-z]{3})/
private_constant :SCRIPT_REGEX
# ISO 3166-1 or UN M.49
REGION_REGEX = /(?:[A-Z]{2}|\d{3})/
private_constant :REGION_REGEX
LOCALE_REGEX = /\A((?:#{LANGUAGE_REGEX}|#{REGION_REGEX}|#{SCRIPT_REGEX})(?:-|$)){1,3}\Z/
private_constant :LOCALE_REGEX
def self.parse(string)
if (locale = try_parse(string))
return locale
end
raise ParserError, "'#{string}' cannot be parsed to a #{self}"
end
sig { params(string: String).returns(T.nilable(T.attached_class)) }
def self.try_parse(string)
return if string.blank?
scanner = StringScanner.new(string)
if (language = scanner.scan(LANGUAGE_REGEX))
sep = scanner.scan("-")
return if (sep && scanner.eos?) || (sep.nil? && !scanner.eos?)
end
if (script = scanner.scan(SCRIPT_REGEX))
sep = scanner.scan("-")
return if (sep && scanner.eos?) || (sep.nil? && !scanner.eos?)
end
region = scanner.scan(REGION_REGEX)
return unless scanner.eos?
new(language, script, region)
end
attr_reader :language, :script, :region
def initialize(language, script, region)
raise ArgumentError, "#{self.class} cannot be empty" if language.nil? && region.nil? && script.nil?
{
language:,
script:,
region:,
}.each do |key, value|
next if value.nil?
regex = self.class.const_get(:"#{key.upcase}_REGEX")
raise ParserError, "'#{value}' does not match #{regex}" unless value&.match?(regex)
instance_variable_set(:"@#{key}", value)
end
end
def include?(other)
unless other.is_a?(self.class)
other = self.class.try_parse(other)
return false if other.nil?
end
[:language, :script, :region].all? do |var|
if other.public_send(var).nil?
true
else
public_send(var) == other.public_send(var)
end
end
end
def eql?(other)
unless other.is_a?(self.class)
other = self.class.try_parse(other)
return false if other.nil?
end
[:language, :script, :region].all? do |var|
public_send(var) == other.public_send(var)
end
end
alias == eql?
def detect(locale_groups)
locale_groups.find { |locales| locales.any? { |locale| eql?(locale) } } ||
locale_groups.find { |locales| locales.any? { |locale| include?(locale) } }
end
sig { returns(String) }
def to_s
[@language, @script, @region].compact.join("-")
end
end