mirror of
https://github.com/Homebrew/brew.git
synced 2025-07-14 16:09:03 +08:00

- Previously I thought that comments were fine to discourage people from wasting their time trying to bump things that used `undef` that Sorbet didn't support. But RuboCop is better at this since it'll complain if the comments are unnecessary. - Suggested in https://github.com/Homebrew/brew/pull/18018#issuecomment-2283369501. - I've gone for a mixture of `rubocop:disable` for the files that can't be `typed: strict` (use of undef, required before everything else, etc) and `rubocop:todo` for everything else that should be tried to make strictly typed. There's no functional difference between the two as `rubocop:todo` is `rubocop:disable` with a different name. - And I entirely disabled the cop for the docs/ directory since `typed: strict` isn't going to gain us anything for some Markdown linting config files. - This means that now it's easier to track what needs to be done rather than relying on checklists of files in our big Sorbet issue: ```shell $ git grep 'typed: true # rubocop:todo Sorbet/StrictSigil' | wc -l 268 ``` - And this is confirmed working for new files: ```shell $ git status On branch use-rubocop-for-sorbet-strict-sigils Untracked files: (use "git add <file>..." to include in what will be committed) Library/Homebrew/bad.rb Library/Homebrew/good.rb nothing added to commit but untracked files present (use "git add" to track) $ brew style Offenses: bad.rb:1:1: C: Sorbet/StrictSigil: Sorbet sigil should be at least strict got true. ^^^^^^^^^^^^^ 1340 files inspected, 1 offense detected ```
152 lines
2.5 KiB
Ruby
152 lines
2.5 KiB
Ruby
# typed: true # rubocop:todo Sorbet/StrictSigil
|
|
# frozen_string_literal: true
|
|
|
|
# A formula option.
|
|
class Option
|
|
attr_reader :name, :description, :flag
|
|
|
|
def initialize(name, description = "")
|
|
@name = name
|
|
@flag = "--#{name}"
|
|
@description = description
|
|
end
|
|
|
|
sig { returns(String) }
|
|
def to_s = flag
|
|
|
|
def <=>(other)
|
|
return unless other.is_a?(Option)
|
|
|
|
name <=> other.name
|
|
end
|
|
|
|
def ==(other)
|
|
instance_of?(other.class) && name == other.name
|
|
end
|
|
alias eql? ==
|
|
|
|
def hash
|
|
name.hash
|
|
end
|
|
|
|
sig { returns(String) }
|
|
def inspect
|
|
"#<#{self.class.name}: #{flag.inspect}>"
|
|
end
|
|
end
|
|
|
|
# A deprecated formula option.
|
|
class DeprecatedOption
|
|
attr_reader :old, :current
|
|
|
|
def initialize(old, current)
|
|
@old = old
|
|
@current = current
|
|
end
|
|
|
|
sig { returns(String) }
|
|
def old_flag
|
|
"--#{old}"
|
|
end
|
|
|
|
sig { returns(String) }
|
|
def current_flag
|
|
"--#{current}"
|
|
end
|
|
|
|
def ==(other)
|
|
instance_of?(other.class) && old == other.old && current == other.current
|
|
end
|
|
alias eql? ==
|
|
end
|
|
|
|
# A collection of formula options.
|
|
class Options
|
|
include Enumerable
|
|
|
|
def self.create(array)
|
|
new Array(array).map { |e| Option.new(e[/^--([^=]+=?)(.+)?$/, 1] || e) }
|
|
end
|
|
|
|
def initialize(*args)
|
|
# Ensure this is synced with `initialize_dup` and `freeze` (excluding simple objects like integers and booleans)
|
|
@options = Set.new(*args)
|
|
end
|
|
|
|
def initialize_dup(other)
|
|
super
|
|
@options = @options.dup
|
|
end
|
|
|
|
def freeze
|
|
@options.dup
|
|
super
|
|
end
|
|
|
|
def each(*args, &block)
|
|
@options.each(*args, &block)
|
|
end
|
|
|
|
def <<(other)
|
|
@options << other
|
|
self
|
|
end
|
|
|
|
def +(other)
|
|
self.class.new(@options + other)
|
|
end
|
|
|
|
def -(other)
|
|
self.class.new(@options - other)
|
|
end
|
|
|
|
def &(other)
|
|
self.class.new(@options & other)
|
|
end
|
|
|
|
def |(other)
|
|
self.class.new(@options | other)
|
|
end
|
|
|
|
def *(other)
|
|
@options.to_a * other
|
|
end
|
|
|
|
def ==(other)
|
|
instance_of?(other.class) &&
|
|
to_a == other.to_a
|
|
end
|
|
alias eql? ==
|
|
|
|
def empty?
|
|
@options.empty?
|
|
end
|
|
|
|
def as_flags
|
|
map(&:flag)
|
|
end
|
|
|
|
def include?(option)
|
|
any? { |opt| opt == option || opt.name == option || opt.flag == option }
|
|
end
|
|
|
|
alias to_ary to_a
|
|
|
|
sig { returns(String) }
|
|
def to_s
|
|
@options.map(&:to_s).join(" ")
|
|
end
|
|
|
|
sig { returns(String) }
|
|
def inspect
|
|
"#<#{self.class.name}: #{to_a.inspect}>"
|
|
end
|
|
|
|
def self.dump_for_formula(formula)
|
|
formula.options.sort_by(&:flag).each do |opt|
|
|
puts "#{opt.flag}\n\t#{opt.description}"
|
|
end
|
|
puts "--HEAD\n\tInstall HEAD version" if formula.head
|
|
end
|
|
end
|