mirror of
https://github.com/Homebrew/brew.git
synced 2025-07-14 16:09:03 +08:00
45978435e7
- Previously I thought that comments were fine to discourage people from wasting their time trying to bump things that used `undef` that Sorbet didn't support. But RuboCop is better at this since it'll complain if the comments are unnecessary. - Suggested in https://github.com/Homebrew/brew/pull/18018#issuecomment-2283369501. - I've gone for a mixture of `rubocop:disable` for the files that can't be `typed: strict` (use of undef, required before everything else, etc) and `rubocop:todo` for everything else that should be tried to make strictly typed. There's no functional difference between the two as `rubocop:todo` is `rubocop:disable` with a different name. - And I entirely disabled the cop for the docs/ directory since `typed: strict` isn't going to gain us anything for some Markdown linting config files. - This means that now it's easier to track what needs to be done rather than relying on checklists of files in our big Sorbet issue: ```shell $ git grep 'typed: true # rubocop:todo Sorbet/StrictSigil' | wc -l 268 ``` - And this is confirmed working for new files: ```shell $ git status On branch use-rubocop-for-sorbet-strict-sigils Untracked files: (use "git add <file>..." to include in what will be committed) Library/Homebrew/bad.rb Library/Homebrew/good.rb nothing added to commit but untracked files present (use "git add" to track) $ brew style Offenses: bad.rb:1:1: C: Sorbet/StrictSigil: Sorbet sigil should be at least strict got true. ^^^^^^^^^^^^^ 1340 files inspected, 1 offense detected ```
67 lines
1.7 KiB
Ruby
67 lines
1.7 KiB
Ruby
# typed: true # rubocop:todo Sorbet/StrictSigil
|
|
# frozen_string_literal: true
|
|
|
|
class Keg
|
|
sig { params(id: String, file: Pathname).returns(T::Boolean) }
|
|
def change_dylib_id(id, file)
|
|
return false if file.dylib_id == id
|
|
|
|
@require_relocation = true
|
|
odebug "Changing dylib ID of #{file}\n from #{file.dylib_id}\n to #{id}"
|
|
file.change_dylib_id(id, strict: false)
|
|
true
|
|
rescue MachO::MachOError
|
|
onoe <<~EOS
|
|
Failed changing dylib ID of #{file}
|
|
from #{file.dylib_id}
|
|
to #{id}
|
|
EOS
|
|
raise
|
|
end
|
|
|
|
sig { params(old: String, new: String, file: Pathname).returns(T::Boolean) }
|
|
def change_install_name(old, new, file)
|
|
return false if old == new
|
|
|
|
@require_relocation = true
|
|
odebug "Changing install name in #{file}\n from #{old}\n to #{new}"
|
|
file.change_install_name(old, new, strict: false)
|
|
true
|
|
rescue MachO::MachOError
|
|
onoe <<~EOS
|
|
Failed changing install name in #{file}
|
|
from #{old}
|
|
to #{new}
|
|
EOS
|
|
raise
|
|
end
|
|
|
|
def change_rpath(old, new, file)
|
|
return false if old == new
|
|
|
|
@require_relocation = true
|
|
odebug "Changing rpath in #{file}\n from #{old}\n to #{new}"
|
|
file.change_rpath(old, new, strict: false)
|
|
true
|
|
rescue MachO::MachOError
|
|
onoe <<~EOS
|
|
Failed changing rpath in #{file}
|
|
from #{old}
|
|
to #{new}
|
|
EOS
|
|
raise
|
|
end
|
|
|
|
sig { params(rpath: String, file: MachOShim).returns(T::Boolean) }
|
|
def delete_rpath(rpath, file)
|
|
odebug "Deleting rpath #{rpath} in #{file}"
|
|
file.delete_rpath(rpath, strict: false)
|
|
true
|
|
rescue MachO::MachOError
|
|
onoe <<~EOS
|
|
Failed deleting rpath #{rpath} in #{file}
|
|
EOS
|
|
raise
|
|
end
|
|
end
|