Sam Ford d1297c0974
node: add shebang rewriting
Formulae that depend on `node` sometimes contain files that use a
shebang like `#!/usr/bin/env node` and this can lead to issues when
the `node` in a user's environment isn't brewed `node`.

For example, some node modules are compiled when the formula is built
but if the user's `node` is a different major version than brew's
`node`, the differing `NODE_MODULE_VERSION` can produce an error when
certain parts of the application are used. The formula may build and
test fine and the issue may only become apparent when more of the
application is exercised.

This adds a `Language::Node::Shebang` module (borrowing from the
existing Perl and Python examples), which allows us to use
`rewrite_shebang detected_node_shebang, ...` in formulae to address
this type of issue.
2023-08-15 00:53:41 -04:00

120 lines
3.9 KiB
Ruby

# typed: true
# frozen_string_literal: true
module Language
# Helper functions for Node formulae.
#
# @api public
module Node
sig { returns(String) }
def self.npm_cache_config
"cache=#{HOMEBREW_CACHE}/npm_cache"
end
def self.pack_for_installation
# Homebrew assumes the buildpath/testpath will always be disposable
# and from npm 5.0.0 the logic changed so that when a directory is
# fed to `npm install` only symlinks are created linking back to that
# directory, consequently breaking that assumption. We require a tarball
# because npm install creates a "real" installation when fed a tarball.
if (package = Pathname("package.json")) && package.exist?
begin
pkg_json = JSON.parse(package.read)
rescue JSON::ParserError
opoo "Could not parse package.json!"
raise
end
prepare_removed = pkg_json["scripts"]&.delete("prepare")
prepack_removed = pkg_json["scripts"]&.delete("prepack")
postpack_removed = pkg_json["scripts"]&.delete("postpack")
package.atomic_write(JSON.pretty_generate(pkg_json)) if prepare_removed || prepack_removed || postpack_removed
end
output = Utils.popen_read("npm", "pack", "--ignore-scripts")
raise "npm failed to pack #{Dir.pwd}" if !$CHILD_STATUS.exitstatus.zero? || output.lines.empty?
output.lines.last.chomp
end
def self.setup_npm_environment
# guard that this is only run once
return if @env_set
@env_set = true
# explicitly use our npm and node-gyp executables instead of the user
# managed ones in HOMEBREW_PREFIX/lib/node_modules which might be broken
begin
ENV.prepend_path "PATH", Formula["node"].opt_libexec/"bin"
rescue FormulaUnavailableError
nil
end
end
def self.std_npm_install_args(libexec)
setup_npm_environment
# tell npm to not install .brew_home by adding it to the .npmignore file
# (or creating a new one if no .npmignore file already exists)
open(".npmignore", "a") { |f| f.write("\n.brew_home\n") }
pack = pack_for_installation
# npm 7 requires that these dirs exist before install
(libexec/"lib").mkpath
# npm install args for global style module format installed into libexec
args = %W[
-ddd
--global
--build-from-source
--#{npm_cache_config}
--prefix=#{libexec}
#{Dir.pwd}/#{pack}
]
args << "--unsafe-perm" if Process.uid.zero?
args
end
sig { returns(T::Array[String]) }
def self.local_npm_install_args
setup_npm_environment
# npm install args for local style module format
%W[
-ddd
--build-from-source
--#{npm_cache_config}
]
end
# Mixin module for {Formula} adding shebang rewrite features.
module Shebang
module_function
# A regex to match potential shebang permutations.
NODE_SHEBANG_REGEX = %r{^#! ?/usr/bin/(?:env )?node( |$)}.freeze
# The length of the longest shebang matching `SHEBANG_REGEX`.
NODE_SHEBANG_MAX_LENGTH = "#! /usr/bin/env node ".length
# @private
sig { params(node_path: T.any(String, Pathname)).returns(Utils::Shebang::RewriteInfo) }
def node_shebang_rewrite_info(node_path)
Utils::Shebang::RewriteInfo.new(
NODE_SHEBANG_REGEX,
NODE_SHEBANG_MAX_LENGTH,
"#{node_path}\\1",
)
end
sig { params(formula: T.untyped).returns(Utils::Shebang::RewriteInfo) }
def detected_node_shebang(formula = self)
node_deps = formula.deps.map(&:name).grep(/^node(@.+)?$/)
raise ShebangDetectionError.new("Node", "formula does not depend on Node") if node_deps.empty?
raise ShebangDetectionError.new("Node", "formula has multiple Node dependencies") if node_deps.length > 1
node_shebang_rewrite_info(Formula[node_deps.first].opt_bin/"node")
end
end
end
end