mirror of
https://github.com/Homebrew/brew.git
synced 2025-07-14 16:09:03 +08:00
0fc1eb534b
- Some of these I bumped to `typed: strict`, some of them I added intermediary type signatures to some of the methods to make my life easier in the (near, hopefully) future. - Turns out that RuboCop node matchers that end in `?` can return `nil` if they don't match anything, not `false`.
81 lines
2.0 KiB
Ruby
81 lines
2.0 KiB
Ruby
# typed: strict
|
|
# frozen_string_literal: true
|
|
|
|
module RuboCop
|
|
module Cop
|
|
module Homebrew
|
|
# Checks for code that can be simplified using `Object#present?`.
|
|
#
|
|
# ### Example
|
|
#
|
|
# ```ruby
|
|
# # bad
|
|
# !foo.nil? && !foo.empty?
|
|
#
|
|
# # bad
|
|
# foo != nil && !foo.empty?
|
|
#
|
|
# # good
|
|
# foo.present?
|
|
# ```
|
|
class Present < Base
|
|
extend AutoCorrector
|
|
|
|
MSG = "Use `%<prefer>s` instead of `%<current>s`."
|
|
|
|
def_node_matcher :exists_and_not_empty?, <<~PATTERN
|
|
(and
|
|
{
|
|
(send (send $_ :nil?) :!)
|
|
(send (send $_ :!) :!)
|
|
(send $_ :!= nil)
|
|
$_
|
|
}
|
|
{
|
|
(send (send $_ :empty?) :!)
|
|
}
|
|
)
|
|
PATTERN
|
|
|
|
sig { params(node: RuboCop::AST::AndNode).void }
|
|
def on_and(node)
|
|
exists_and_not_empty?(node) do |var1, var2|
|
|
return if var1 != var2
|
|
|
|
message = format(MSG, prefer: replacement(var1), current: node.source)
|
|
|
|
add_offense(node, message:) do |corrector|
|
|
autocorrect(corrector, node)
|
|
end
|
|
end
|
|
end
|
|
|
|
sig { params(node: RuboCop::AST::OrNode).void }
|
|
def on_or(node)
|
|
exists_and_not_empty?(node) do |var1, var2|
|
|
return if var1 != var2
|
|
|
|
add_offense(node, message: MSG) do |corrector|
|
|
autocorrect(corrector, node)
|
|
end
|
|
end
|
|
end
|
|
|
|
sig { params(corrector: RuboCop::Cop::Corrector, node: RuboCop::AST::Node).void }
|
|
def autocorrect(corrector, node)
|
|
variable1, _variable2 = exists_and_not_empty?(node)
|
|
range = node.source_range
|
|
corrector.replace(range, replacement(variable1))
|
|
end
|
|
|
|
private
|
|
|
|
sig { params(node: T.nilable(RuboCop::AST::Node)).returns(String) }
|
|
def replacement(node)
|
|
node.respond_to?(:source) ? "#{node&.source}.present?" : "present?"
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|