40 lines
1.1 KiB
Ruby
Raw Normal View History

rubocop: Use `Sorbet/StrictSigil` as it's better than comments - Previously I thought that comments were fine to discourage people from wasting their time trying to bump things that used `undef` that Sorbet didn't support. But RuboCop is better at this since it'll complain if the comments are unnecessary. - Suggested in https://github.com/Homebrew/brew/pull/18018#issuecomment-2283369501. - I've gone for a mixture of `rubocop:disable` for the files that can't be `typed: strict` (use of undef, required before everything else, etc) and `rubocop:todo` for everything else that should be tried to make strictly typed. There's no functional difference between the two as `rubocop:todo` is `rubocop:disable` with a different name. - And I entirely disabled the cop for the docs/ directory since `typed: strict` isn't going to gain us anything for some Markdown linting config files. - This means that now it's easier to track what needs to be done rather than relying on checklists of files in our big Sorbet issue: ```shell $ git grep 'typed: true # rubocop:todo Sorbet/StrictSigil' | wc -l 268 ``` - And this is confirmed working for new files: ```shell $ git status On branch use-rubocop-for-sorbet-strict-sigils Untracked files: (use "git add <file>..." to include in what will be committed) Library/Homebrew/bad.rb Library/Homebrew/good.rb nothing added to commit but untracked files present (use "git add" to track) $ brew style Offenses: bad.rb:1:1: C: Sorbet/StrictSigil: Sorbet sigil should be at least strict got true. ^^^^^^^^^^^^^ 1340 files inspected, 1 offense detected ```
2024-08-12 10:30:59 +01:00
# typed: true # rubocop:todo Sorbet/StrictSigil
# frozen_string_literal: true
require "cask/utils"
2023-03-27 11:28:59 +11:00
require "extend/on_system"
2018-09-06 08:29:14 +02:00
module Cask
2016-09-24 13:52:43 +02:00
class DSL
2020-08-24 23:09:43 +02:00
# Superclass for all stanzas which take a block.
2016-09-24 13:52:43 +02:00
class Base
extend Forwardable
2016-08-18 22:11:42 +03:00
2016-09-24 13:52:43 +02:00
def initialize(cask, command = SystemCommand)
@cask = cask
@command = command
end
2016-08-18 22:11:42 +03:00
2023-03-27 11:28:59 +11:00
def_delegators :@cask, :token, :version, :caskroom_path, :staged_path, :appdir, :language, :arch
2016-08-18 22:11:42 +03:00
2017-10-04 15:47:53 +02:00
def system_command(executable, **options)
@command.run!(executable, **options)
2016-09-24 13:52:43 +02:00
end
2016-08-18 22:11:42 +03:00
# No need to define it as it's the default/superclass implementation.
2020-09-01 14:05:52 +01:00
# rubocop:disable Style/MissingRespondToMissing
2016-09-24 13:52:43 +02:00
def method_missing(method, *)
if method
2023-03-12 17:06:29 -07:00
underscored_class = T.must(self.class.name).gsub(/([[:lower:]])([[:upper:]][[:lower:]])/, '\1_\2').downcase
2017-10-04 15:47:53 +02:00
section = underscored_class.split("::").last
2016-09-24 13:52:43 +02:00
Utils.method_missing_message(method, @cask.to_s, section)
nil
else
super
end
end
2020-09-01 14:05:52 +01:00
# rubocop:enable Style/MissingRespondToMissing
2016-09-24 13:52:43 +02:00
end
2016-08-18 22:11:42 +03:00
end
end