mirror of
https://github.com/Homebrew/brew.git
synced 2025-07-14 16:09:03 +08:00
45978435e7
- Previously I thought that comments were fine to discourage people from wasting their time trying to bump things that used `undef` that Sorbet didn't support. But RuboCop is better at this since it'll complain if the comments are unnecessary. - Suggested in https://github.com/Homebrew/brew/pull/18018#issuecomment-2283369501. - I've gone for a mixture of `rubocop:disable` for the files that can't be `typed: strict` (use of undef, required before everything else, etc) and `rubocop:todo` for everything else that should be tried to make strictly typed. There's no functional difference between the two as `rubocop:todo` is `rubocop:disable` with a different name. - And I entirely disabled the cop for the docs/ directory since `typed: strict` isn't going to gain us anything for some Markdown linting config files. - This means that now it's easier to track what needs to be done rather than relying on checklists of files in our big Sorbet issue: ```shell $ git grep 'typed: true # rubocop:todo Sorbet/StrictSigil' | wc -l 268 ``` - And this is confirmed working for new files: ```shell $ git status On branch use-rubocop-for-sorbet-strict-sigils Untracked files: (use "git add <file>..." to include in what will be committed) Library/Homebrew/bad.rb Library/Homebrew/good.rb nothing added to commit but untracked files present (use "git add" to track) $ brew style Offenses: bad.rb:1:1: C: Sorbet/StrictSigil: Sorbet sigil should be at least strict got true. ^^^^^^^^^^^^^ 1340 files inspected, 1 offense detected ```
40 lines
1.1 KiB
Ruby
40 lines
1.1 KiB
Ruby
# typed: true # rubocop:todo Sorbet/StrictSigil
|
|
# frozen_string_literal: true
|
|
|
|
require "cask/utils"
|
|
require "extend/on_system"
|
|
|
|
module Cask
|
|
class DSL
|
|
# Superclass for all stanzas which take a block.
|
|
class Base
|
|
extend Forwardable
|
|
|
|
def initialize(cask, command = SystemCommand)
|
|
@cask = cask
|
|
@command = command
|
|
end
|
|
|
|
def_delegators :@cask, :token, :version, :caskroom_path, :staged_path, :appdir, :language, :arch
|
|
|
|
def system_command(executable, **options)
|
|
@command.run!(executable, **options)
|
|
end
|
|
|
|
# No need to define it as it's the default/superclass implementation.
|
|
# rubocop:disable Style/MissingRespondToMissing
|
|
def method_missing(method, *)
|
|
if method
|
|
underscored_class = T.must(self.class.name).gsub(/([[:lower:]])([[:upper:]][[:lower:]])/, '\1_\2').downcase
|
|
section = underscored_class.split("::").last
|
|
Utils.method_missing_message(method, @cask.to_s, section)
|
|
nil
|
|
else
|
|
super
|
|
end
|
|
end
|
|
# rubocop:enable Style/MissingRespondToMissing
|
|
end
|
|
end
|
|
end
|