2024-07-14 00:24:16 +00:00
|
|
|
# typed: strict
|
2019-04-19 15:38:03 +09:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2023-02-20 10:22:39 -08:00
|
|
|
require "rubocops/extend/formula_cop"
|
2017-05-24 21:07:50 +05:30
|
|
|
|
|
|
|
module RuboCop
|
|
|
|
module Cop
|
|
|
|
module FormulaAudit
|
2020-11-05 17:17:03 -05:00
|
|
|
# This cop audits `option`s in formulae.
|
2023-02-20 18:10:59 -08:00
|
|
|
class Options < FormulaCop
|
2019-04-19 15:38:03 +09:00
|
|
|
DEPRECATION_MSG = "macOS has been 64-bit only since 10.6 so 32-bit options are deprecated."
|
|
|
|
UNI_DEPRECATION_MSG = "macOS has been 64-bit only since 10.6 so universal options are deprecated."
|
2017-05-24 21:07:50 +05:30
|
|
|
|
2020-01-08 15:38:48 -05:00
|
|
|
DEP_OPTION = "Formulae in homebrew/core should not use `deprecated_option`."
|
|
|
|
OPTION = "Formulae in homebrew/core should not use `option`."
|
2019-01-22 13:30:24 +00:00
|
|
|
|
2024-07-07 15:18:29 -04:00
|
|
|
sig { override.params(formula_nodes: FormulaNodes).void }
|
|
|
|
def audit_formula(formula_nodes)
|
|
|
|
return if (body_node = formula_nodes.body_node).nil?
|
2022-11-05 04:17:50 +00:00
|
|
|
|
2017-05-24 21:07:50 +05:30
|
|
|
option_call_nodes = find_every_method_call_by_name(body_node, :option)
|
|
|
|
option_call_nodes.each do |option_call|
|
|
|
|
option = parameters(option_call).first
|
|
|
|
problem DEPRECATION_MSG if regex_match_group(option, /32-bit/)
|
2017-07-14 21:11:53 +05:30
|
|
|
|
|
|
|
offending_node(option_call)
|
2020-09-01 14:05:52 +01:00
|
|
|
option = string_content(option)
|
2018-10-27 21:47:58 +10:00
|
|
|
problem UNI_DEPRECATION_MSG if option == "universal"
|
2017-07-14 21:11:53 +05:30
|
|
|
|
2023-12-27 13:00:48 -08:00
|
|
|
if !/with(out)?-/.match?(option) &&
|
2017-07-14 21:11:53 +05:30
|
|
|
option != "cxx11" &&
|
|
|
|
option != "universal"
|
2025-05-30 16:42:32 -04:00
|
|
|
problem "Options should begin with `with` or `without`. " \
|
2022-06-28 10:17:14 +01:00
|
|
|
"Migrate '--#{option}' with `deprecated_option`."
|
2017-07-14 21:11:53 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
next unless option =~ /^with(out)?-(?:checks?|tests)$/
|
|
|
|
next if depends_on?("check", :optional, :recommended)
|
2018-09-17 02:45:00 +02:00
|
|
|
|
2022-06-28 10:17:14 +01:00
|
|
|
problem "Use '--with#{Regexp.last_match(1)}-test' instead of '--#{option}'. " \
|
|
|
|
"Migrate '--#{option}' with `deprecated_option`."
|
2017-07-14 21:11:53 +05:30
|
|
|
end
|
2019-01-22 13:30:24 +00:00
|
|
|
|
2020-04-11 14:20:07 +01:00
|
|
|
return if formula_tap != "homebrew-core"
|
2019-01-22 13:30:24 +00:00
|
|
|
|
|
|
|
problem DEP_OPTION if method_called_ever?(body_node, :deprecated_option)
|
|
|
|
problem OPTION if method_called_ever?(body_node, :option)
|
2017-07-14 21:11:53 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2017-05-24 21:07:50 +05:30
|
|
|
end
|
|
|
|
end
|