53 lines
2.0 KiB
Ruby
Raw Normal View History

# typed: strict
# frozen_string_literal: true
2023-02-20 10:22:39 -08:00
require "rubocops/extend/formula_cop"
module RuboCop
module Cop
module FormulaAudit
# This cop audits `option`s in formulae.
2023-02-20 18:10:59 -08:00
class Options < FormulaCop
DEPRECATION_MSG = "macOS has been 64-bit only since 10.6 so 32-bit options are deprecated."
UNI_DEPRECATION_MSG = "macOS has been 64-bit only since 10.6 so universal options are deprecated."
DEP_OPTION = "Formulae in homebrew/core should not use `deprecated_option`."
OPTION = "Formulae in homebrew/core should not use `option`."
sig { override.params(formula_nodes: FormulaNodes).void }
def audit_formula(formula_nodes)
return if (body_node = formula_nodes.body_node).nil?
option_call_nodes = find_every_method_call_by_name(body_node, :option)
option_call_nodes.each do |option_call|
option = parameters(option_call).first
problem DEPRECATION_MSG if regex_match_group(option, /32-bit/)
offending_node(option_call)
2020-09-01 14:05:52 +01:00
option = string_content(option)
2018-10-27 21:47:58 +10:00
problem UNI_DEPRECATION_MSG if option == "universal"
if !/with(out)?-/.match?(option) &&
option != "cxx11" &&
option != "universal"
problem "Options should begin with `with` or `without`. " \
2022-06-28 10:17:14 +01:00
"Migrate '--#{option}' with `deprecated_option`."
end
next unless option =~ /^with(out)?-(?:checks?|tests)$/
next if depends_on?("check", :optional, :recommended)
2018-09-17 02:45:00 +02:00
2022-06-28 10:17:14 +01:00
problem "Use '--with#{Regexp.last_match(1)}-test' instead of '--#{option}'. " \
"Migrate '--#{option}' with `deprecated_option`."
end
2020-04-11 14:20:07 +01:00
return if formula_tap != "homebrew-core"
problem DEP_OPTION if method_called_ever?(body_node, :deprecated_option)
problem OPTION if method_called_ever?(body_node, :option)
end
end
end
end
end