Mike McQuaid
eec800149f
Merge pull request #20238 from Homebrew/fix_rubocop_fixture_style
...
`fixtures/rubocop@x.x.x.rbi`: fix style.
2025-07-11 13:17:54 +00:00
Mike McQuaid
370ce002e9
Merge pull request #20237 from Homebrew/actionlint_skip_homebrew_brew
...
style: fix skipping actionlint checks on Homebrew/brew.
2025-07-11 13:06:52 +00:00
Issy Long
7f333ab6ec
Merge pull request #20235 from Homebrew/slash-not-plus-in-paths
...
rubocops/text: Prefer `lib/"string"` over `lib+"string"`
2025-07-11 12:56:54 +00:00
Mike McQuaid
607ffafd9f
fixtures/rubocop@x.x.x.rbi: fix style.
...
At least for me locally: `brew style` complains about this and
`brew style --fix` autocorrects it.
2025-07-11 13:54:51 +01:00
Mike McQuaid
26bb16e26d
style: fix skipping actionlint checks on Homebrew/brew.
...
If we're running `brew style` on Homebrew/brew: let's ensure that we
don't run the `actionlint` checks as they are handled by the dedicated
`actionlint.yml` workflow.
2025-07-11 13:51:59 +01:00
Mike McQuaid
36a4cb42ed
Merge pull request #20233 from Homebrew/zero_zero_zero_zero
...
Add ZeroZeroZeroZero cop
2025-07-11 12:44:23 +00:00
Issy Long
d4d1b4a22a
rubocops/text: Prefer lib/"string" over lib+"string"
...
- I found a few occurrences of this pattern from
https://github.com/orgs/Homebrew/projects/5?pane=issue&itemId=97021840 ,
that is an automated style request for:
`core: use / instead of + operator in e.g. (lib+"lv").install "lv.hlp"`.
- Upon adding tests I realised that there's also the `prefix + "bin"`
case that's already handled differently, so let's combine the handling
given it's the same `+` that's wrong.
2025-07-11 13:41:58 +01:00
Mike McQuaid
3e0b0c1b32
Merge pull request #20232 from Homebrew/pathname_instance_variables
...
Improve some `Pathname` instance variable handling
2025-07-11 08:21:24 +00:00
Mike McQuaid
d57efd9ea2
Improve some Pathname instance variable handling
...
Will fix or at least partly address:
```
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/os/linux/elf.rb:225: warning: The class Pathname reached 8 shape variations, instance variables accesses will be slower and memory usage increased.
35
It is recommended to define instance variables in a consistent order, for instance by eagerly defining them all in the #initialize method.
```
2025-07-11 08:02:27 +00:00
Mike McQuaid
71bab462e1
Add ZeroZeroZeroZero cop
...
Add a new RuboCop to detect the use of 0.0.0.0 in formulae which
indicates binding to all network interfaces, internally or externally,
so is a bad default and potentially a security risk.
Co-authored-by: Issy Long <me@issylong.com>
2025-07-11 08:24:19 +01:00
Carlo Cabrera
5692ea6c17
Merge pull request #20236 from Homebrew/sync-shared-config
...
Synchronize shared configuration
2025-07-11 06:55:42 +00:00
BrewTestBot
8efb804e4e
actionlint.yml: update to match main configuration
2025-07-11 06:36:02 +00:00
Patrick Linnane
a65b9d0128
Merge pull request #20234 from Homebrew/sync-shared-config
...
Synchronize shared configuration
2025-07-10 17:25:05 +00:00
BrewTestBot
e4893037ae
dependabot.yml: update to match main configuration
2025-07-10 17:09:22 +00:00
Mike McQuaid
a2bf23ef70
Merge pull request #20224 from Homebrew/cask_dumper_old_tokens
...
Support Cask renames when installing/dumping
2025-07-10 13:54:26 +00:00
Carlo Cabrera
0b99d57621
Merge pull request #20226 from Homebrew/formula-loading-stdout
...
formulary: prevent formulae from printing to stdout while being loaded
2025-07-10 12:43:42 +00:00
Carlo Cabrera
69ce5edd14
formulary: improve style
...
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2025-07-10 20:27:52 +08:00
Mike McQuaid
b53f3b570c
Merge pull request #20228 from Paulchen5/use-github-secrets-in-workflow
...
Replace `github.token` by `secrets.GITHUB_TOKEN`
2025-07-10 08:32:40 +00:00
Mike McQuaid
5bc5d53a23
Merge pull request #20229 from Homebrew/attestation_opt_in
...
attestation: require explicit opt-in.
2025-07-10 08:24:48 +00:00
Mike McQuaid
17762fa77a
attestation: require explicit opt-in.
...
Work on this has stalled a bit and it slows things down so let's require
an explicit opt-in to use it.
While we're here, remove the silent/implicit opt-out for CI, too.
2025-07-10 09:10:08 +01:00
Mike McQuaid
e8bfa23877
Support Cask renames when installing/dumping
...
This adds support for Cask old tokens used for renames of Casks.
We'll now correctly check these at installation time to avoid repeatedly
installing renamed Casks and dump them in the Brewfile. We also use this
logic to avoid cleaning up renamed Casks.
2025-07-10 08:05:36 +00:00
Paulchen
b7b369270e
Replace github.token by secrets.GITHUB_TOKEN
2025-07-10 17:01:29 +09:00
Carlo Cabrera
d46d315cc1
Merge pull request #20227 from Homebrew/sync-shared-config
...
Synchronize shared configuration
2025-07-09 22:07:13 +00:00
BrewTestBot
455a461406
actionlint.yml: update to match main configuration
2025-07-09 21:53:17 +00:00
Carlo Cabrera
6141c6a181
formulary: prevent formulae from printing to stdout while being loaded
...
Formulae can execute arbitrary Ruby code when being loaded. In
particular, they can print to stdout with methods like `puts`. This can
break the parsing of output of commands like `brew info --json=v2`.
Let's fix that by capturing the output to stdout, and then printing
those messages to stderr instead (using `opoo` to try to discourage
formula authors from doing this).
2025-07-10 03:58:39 +08:00
Issy Long
ab3955209e
Merge pull request #20225 from Homebrew/rename-bundle-tests
...
Rename the `brew_{dumper,installer}_spec.rb` files
2025-07-09 17:42:23 +00:00
Issy Long
50c3181cdb
Rename the brew_{dumper,installer}_spec.rb files
...
- The classes were renamed in 990c1efc16aad71254ae89e0b7983eee97696c72,
but I forgot to rename the test filenames.
2025-07-09 17:47:08 +01:00
Eric Knibbe
700d67a85e
Merge pull request #20220 from Homebrew/download_strategy-wanted-headers
...
download_strategy: only require content-disposition header
2025-07-07 17:52:52 +00:00
Eric Knibbe
0f2131484d
download_strategy: only require content-disposition header
2025-07-07 13:16:33 -04:00
Mike McQuaid
5ec756e0ca
Merge pull request #20193 from Homebrew/skinny-rubocop-rbi
...
Keep only the parts of `rubocop.rbi` that we actually use
2025-07-07 16:59:45 +00:00
Bo Anderson
d88a0e46fc
Merge pull request #20221 from Homebrew/shfmt-fix
...
style: run shfmt on real brew
2025-07-07 16:50:11 +00:00
Bo Anderson
2dfb8c0b76
style: run shfmt on real brew
2025-07-07 17:28:31 +01:00
Patrick Linnane
114d66082d
Merge pull request #20215 from Homebrew/sorbet-files-update
...
sorbet: Update RBI files.
2025-07-05 05:49:20 +00:00
BrewTestBot
d010adb903
sorbet: Update RBI files.
...
Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/sorbet.yml ) workflow.
2025-07-05 00:29:43 +00:00
Douglas Eichelberger
43b72d3633
Merge pull request #20213 from Homebrew/dug-20205
...
Exit non-zero when pinning uninstalled formula
2025-07-04 21:56:14 +00:00
Issy Long
1286a3676c
Merge pull request #20214 from Homebrew/the-old-brews-flag-needs-to-remain-for-backwards-compatibility
...
Retain the old `brew bundle --brews` flag for compatibility
2025-07-04 21:52:49 +00:00
Issy Long
ce8bf906c1
Retain the old brew bundle --brews flag for compatibility
...
https://github.com/Homebrew/brew/pull/20209#discussion_r2186099917
2025-07-04 22:02:59 +01:00
Douglas Eichelberger
e78cc286e0
Keep exiting zero on already pinned formulae
2025-07-04 13:55:12 -07:00
Douglas Eichelberger
f4bcda325a
Exit non-zero when pinning uninstalled formula
2025-07-04 13:28:54 -07:00
Issy Long
495b5bedde
Merge pull request #20209 from Homebrew/bundle-rename-brews-to-formulae
...
bundle: Rename "brews" to "formulae" for consistency
2025-07-04 20:21:38 +00:00
Issy Long
990c1efc16
bundle: Rename "brews" to "formulae" for consistency
...
- Homebrew Bundle referred to formulae as "brews". But it referred to
casks as "casks" and taps as "taps".
- Let's use the same terminology everywhere.
- (I know that `brew "hello"` is the formula syntax in the Brewfile, so
I'm not changing that (though would be up for it, in a backwards
compatible manner), just making the code more consistent.)
2025-07-04 21:08:37 +01:00
Eric Knibbe
b57557dc3d
Merge pull request #20210 from Homebrew/formula-download-strategies
...
Formula-Cookbook: improve download strategy info
2025-07-04 19:25:40 +00:00
Eric Knibbe
bb372b2665
Formula-Cookbook: improve download strategy info
2025-07-04 15:12:32 -04:00
Patrick Linnane
727804bb08
Merge pull request #20206 from osalbahr/docs-update-dnf-commands
...
docs/Homebrew-on-Linux: update dnf5 syntax, centos/rhel section
2025-07-04 18:24:41 +00:00
Patrick Linnane
5c8fe3a339
Merge pull request #20212 from Homebrew/sponsors-maintainers-man-completions
...
Update manpage and completions.
2025-07-04 18:15:15 +00:00
BrewTestBot
37f1e48538
Update manpage and completions.
...
Autogenerated by the [sponsors-maintainers-man-completions](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/sponsors-maintainers-man-completions.yml ) workflow.
2025-07-04 17:42:58 +00:00
Eric Knibbe
be6c62b1d9
Merge pull request #20211 from Homebrew/fix-brew-info
...
cmd/info: fix `brew info <formula>`
2025-07-04 17:23:47 +00:00
Eric Knibbe
a7471e449e
cmd/info: fix brew info <formula>
2025-07-04 10:33:11 -04:00
Issy Long
a36f8af593
Merge pull request #20208 from Homebrew/dependabot/github_actions/github-actions-384b59e5c3
...
build(deps): bump github/codeql-action from 3.29.0 to 3.29.2 in the github-actions group
2025-07-04 10:13:16 +00:00
dependabot[bot]
998470f4a5
build(deps): bump github/codeql-action in the github-actions group
...
Bumps the github-actions group with 1 update: [github/codeql-action](https://github.com/github/codeql-action ).
Updates `github/codeql-action` from 3.29.0 to 3.29.2
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](https://github.com/github/codeql-action/compare/v3.29.0...181d5eefc20863364f96762470ba6f862bdef56b )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: 3.29.2
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: github-actions
...
Signed-off-by: dependabot[bot] <support@github.com>
2025-07-04 08:59:13 +00:00
