mirrors/brew
1
0
Fork 0
mirror of https://github.com/Homebrew/brew.git synced 2025-07-14 16:09:03 +08:00
Code Issues Packages Projects Releases Wiki Activity
brew/docs/Homebrew-homebrew-cask-Maintainer-Guide.md
Rylan Polster 04f5433dcc
docs: update based on suggestions from code review
2021-05-13 20:14:28 -04:00

3.4 KiB
Raw Blame History

Homebrew/homebrew-cask Maintainer Guide

This guide is intended to help maintainers effectively maintain the cask repositories. It is meant to be used in conjunction with the more generic Maintainer Guidelines.

This guide applies to all four of the cask repositories:

Common Situations

Here is a list of the most common situations that arise in PRs and how to handle them:

  • The version and sha256 both change (keeping the same format): Merge.
  • Only the sha256 changes: Merge unless the version needs to be updated as well. It’s not uncommon for upstream vendors to update versions in-place.
  • livecheck is updated: Use your best judgement and try to make sure that the changes follow the livecheck guidelines.
  • Only the version changes or the version format changes: Use your best judgement and merge if it seems correct (this is relatively rare).
  • Other changes (including adding new casks): Use the Cask Cookbook to determine what's correct.

If in doubt, ask another cask maintainer on GitHub or Slack.

Note that unlike in formulae, casks do not consider the sha256 stanza as meaningful security measure as maintainers cannot realistically check them for authenticity. Casks download from upstream; if a malicious actor compromised a URL, they could just as well compromise a version and make it look like an update.

Merging

Approvals

PRs in the cask repositories should must have at least one approval from a user with write access before they can be merged.

Ideally, this approval will come from another maintainer. If necessary, however, a maintainer can self-approve one of their PRs using the self-approve GitHub Actions workflow to satisfy this requirement. To trigger a self-approval, navigate to the "Self-approve a Pull Request" section of the Actions tab, click on "Run workflow", enter the PR number and click "Run workflow".

Merge Types

In general, using GitHub's Squash and Merge button is the best way to merge a PR. This can be used when the PR modifies only one cask, regardless of the number of commits or whether the commit message format is correct. When merging using this method, the commit message can be modified if needed. Usually, version bump commit messages follow the form Update CASK from OLD_VERSION to NEW_VERSION.

If the PR modifies multiple casks, use the Rebase and Merge button to merge the PR. This will use the commit messages from the PR, so make sure that they are appropriate before merging. If needed, checkout the PR, squash/reword the commits and force-push back to the PR branch to ensure the proper commit format.

Finally, make sure to thank the contributor for submitting a PR!

Other Tips

A maintainer can easily rebase a PR onto the latest master branch by adding a /rebase comment. BrewTestBot will automatically rebase the PR and add a reaction to the comment once the rebase is in progress and complete.